Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The adjoint method in lightning supports qubit unitaries #540

Merged
merged 52 commits into from
Nov 15, 2023

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Oct 31, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
The adjoint method in lightning supports arbitrary non-controlled operations [sc-38319]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@vincentmr vincentmr changed the title Initial commit to add adjoint diff support for circuits with qubit-un… The adjoint method in lightning supports qubit unitaries Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7442701) 99.04% compared to head (b9a205a) 98.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   99.04%   98.94%   -0.10%     
==========================================
  Files         167      202      +35     
  Lines       22047    26655    +4608     
==========================================
+ Hits        21837    26375    +4538     
- Misses        210      280      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Oct 31, 2023
@vincentmr vincentmr marked this pull request as ready for review November 1, 2023 13:59
@vincentmr vincentmr requested a review from a team November 1, 2023 14:30
@vincentmr vincentmr requested a review from mlxd November 2, 2023 15:17
.github/CHANGELOG.md Outdated Show resolved Hide resolved
pennylane_lightning/core/_serialize.py Show resolved Hide resolved
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me! Thanks!

.github/CHANGELOG.md Outdated Show resolved Hide resolved
@vincentmr vincentmr requested a review from trbromley November 14, 2023 15:19
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentmr ! Looks good to me!

@vincentmr vincentmr merged commit bf6e121 into master Nov 15, 2023
76 of 77 checks passed
@vincentmr vincentmr deleted the feature/adjoint_diff_unitary branch November 15, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants